Claude finished @meekrosoft's task in 2m 19s —— View job

PR Review: Fix HEAD resolution in git worktrees

• Phase 1: Static analysis (go build, go vet, go mod tidy)
• Phase 2: Code review
• Phase 3: Post review feedback

Static Analysis

All checks pass: go build ./... ✓, go vet ./... ✓, go mod tidy ✓ (no diff).

Code Review

Production change (internal/gitview/gitView.go): The one-line change from git.PlainOpen to git.PlainOpenWithOptions with EnableDotGitCommonDir: true is the correct fix. This option tells go-git to follow the .git file in worktrees to the shared commondir, allowing proper HEAD resolution. It's backward-compatible — for non-worktree repos this option is a no-op since there's no .git file pointing to a commondir.

Test (internal/gitview/gitView_test.go): Well-structured test that:

• Creates a real git repo, then a worktree via git worktree add
• Validates three key operations: New(), BranchName(), and GetCommitInfoFromCommitSHA("HEAD", ...)
• Uses CombinedOutput() to capture error details on failure
• Cleanup is handled by the existing AfterTest() which removes the entire tmpDir (both repo and worktree live under it)

TODO.md: Follows the repo's slice-tracking convention correctly.

Minor Observations

1. The test shells out to git worktree add via exec.Command, which is reasonable — go-git doesn't have a native worktree-creation API, and using the real git command is the most reliable way to set up this fixture.
2. No cleanup of the git worktree metadata (git worktree remove) before os.RemoveAll — this is fine for test purposes since we're deleting the entire temp directory, but worth noting that in long-running processes stale worktree entries could appear in git worktree list for the parent repo. Not a concern here since the parent repo is also temp.

Summary

Clean, minimal, well-tested fix. The change is backward-compatible, the test covers the important code paths, and the PR follows the repo's TDD and slice conventions. Looks good to merge. 👍

I'd love to hear more about why this is useful? and what was happening without it?

Reply to @tooky 's comment: the make demo command doesn't work inside the worktree - the repo_root() command in the shell scripts that make the dummy data fail.